Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ACM-13003-Fast-cluster-page-load #4110

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

ACM-13003-Fast-cluster-page-load #4110

wants to merge 17 commits into from
+2,277 −158

Conversation

jeswanke
Copy link
Contributor

@jeswanke jeswanke commented Nov 25, 2024 •
edited
Loading

  1. environment label MOCK_CLUSTERS="number" in order to mock that many clusters and
    3 policies and
    44 system apps for each cluster
  2. that context error you found was caused by trying to use PluginContext in acm (mce only it looks like)
  3. there's a new LoadStatusProvider that any plugin can use that tells at what stage LoadData is:
    loadStarted --> the first packet has been received, if the data for that page is in the first packet it can start displaying
    loadCompleted --> the load of all data is done (the old loaded context value)

the first packets are these:
case 'ManagedCluster':
case 'HostedCluster':
case 'ClusterDeployment':
case 'Policy':
case 'PolicySet':
case 'AgentClusterInstall':
case 'ManagedClusterInfo':
case 'ManagedClusterAddOn':
case 'Search':
case 'Secret':

Signed-off-by: John Swanke [email protected]

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeswanke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jeswanke
convert dataContext to LoadStatusContext
5a8ba6e 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
add 3 policy mocks
8603d84 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
virtual machine bug
e50beff 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix tests
42f37c2 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix tests
deeb889 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
test
a087392 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix tests
bfbaf32 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix tests
4012760 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix test
3625690 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
Copy link
Contributor Author

jeswanke commented Dec 1, 2024

/test unit-tests-sonarcloud

1 similar comment
@jeswanke
Copy link
Contributor Author

jeswanke commented Dec 1, 2024

/test unit-tests-sonarcloud

@jeswanke
test
91605ba 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
squash tests
c3737ff 
Signed-off-by: John Swanke <[email protected]>
KevinFCormier
KevinFCormier reviewed Dec 2, 2024
View reviewed changes
Copy link
Contributor

@KevinFCormier KevinFCormier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Noted a bad import here. I will ping you separately about another change, and then re-test. Aiming to deliver this on Thursday (start of Train-22).

frontend/src/ui-components/AcmEmptyState/AcmEmptyState.tsx Outdated Show resolved Hide resolved
@jeswanke
fix import
89f505e 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
Merge branch 'main' of https://github.com/stolostron/console into ACM…
83881a6 
…-13003-Fast-cluster-page-load3

Signed-off-by: John Swanke <[email protected]>
@jeswanke
remove LoadStatusContext
e2545ec 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix tests
1283a08 
Signed-off-by: John Swanke <[email protected]>
@jeswanke
fix test
d6b25e2 
Signed-off-by: John Swanke <[email protected]>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
26.2% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 2, 2024

@jeswanke: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/unit-tests-sonarcloud d6b25e2 link true /test unit-tests-sonarcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jeswanke
Copy link
Contributor Author

jeswanke commented Dec 2, 2024

/test unit-tests-sonarcloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinFCormier KevinFCormier KevinFCormier left review comments

@zlayne zlayne Awaiting requested review from zlayne

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
approved dco-signoff: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeswanke @KevinFCormier